Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elaborate on renderToString without hydration (fixes #61) #69

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Elaborate on renderToString without hydration (fixes #61) #69

merged 1 commit into from
Dec 8, 2020

Conversation

lostfictions
Copy link
Contributor

This PR adds an explanatory note about rendering to static markup without hydration, as discussed in #61.

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@brianespinosa
Copy link
Contributor

TY for this

jescalan
jescalan approved these changes Dec 8, 2020
View reviewed changes
Copy link
Collaborator

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks so much 💖

@jescalan jescalan merged commit 1e0711a into hashicorp:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jescalan jescalan jescalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lostfictions @hashicorp-cla @brianespinosa @jescalan